fjtirado commented on code in PR #4003:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4003#discussion_r2257068874
##########
jbpm/jbpm-flow/src/main/java/org/jbpm/workflow/instance/impl/WorkflowProcessInstanceImpl.java:
##########
@@ -682,7 +682,7 @@ public void signalEvent(String type, Object event) {
logger.debug("Signal {} received with data {} in process instance {}",
type, event, getStringId());
synchronized (this) {
if (getState() != KogitoProcessInstance.STATE_ACTIVE) {
- return;
+ throw new IllegalStateException("Current process instance
state is not active");
Review Comment:
@thien There are test failing, we need to throw the exception here
https://github.com/apache/incubator-kie-kogito-runtimes/blob/main/jbpm/jbpm-flow/src/main/java/org/kie/kogito/process/impl/ProcessServiceImpl.java#L166
(and leave this class untouched)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
