tiagobento commented on code in PR #3211:
URL:
https://github.com/apache/incubator-kie-tools/pull/3211#discussion_r2231810415
##########
packages/dmn-editor/src/diagram/Diagram.tsx:
##########
@@ -918,6 +918,32 @@ export const Diagram = React.forwardRef<DiagramRef, {
container: React.RefObject
dsShape["dc:Bounds"]["@_y"] =
(parentShape["dc:Bounds"]?.["@_y"] ?? 0) +
relativePosinCurrentDS.y;
}
+ // Remove decision from decision service
+ let isInside = true;
Review Comment:
I don't think you need to check whether the Decision node is visually inside
the Decision Service, as when the Decision Service is not in a collapsed state
you can assume the Decision being present in the DRD means it now needs to be
removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
