masayag commented on issue #1621: URL: https://github.com/apache/incubator-kie-issues/issues/1621#issuecomment-3072318871
> Personally, it feels like duplicate functionality (especially when it’s run from a script), but if you need it, let’s implement it We are on the same page with this. I don't think that there is a need to add this at all. All I said is that we can achieve the same functionality by the existing `kn-workflow deploy` command. This is already implemented. there isn't anything to add to it. This is fine on its own: ``` kn workflow deploy --custom-generated-manifests-dir=<full_directory_path> ``` And if there is a need for custom manifests, then the user will have to run 2 command which is fine by me, e.g.: ``` kn-workflow gen-manifest --profile=gitops --image=quay.io/org/repo:tag --custom-generated-manifests-dir=./manifests ``` followed by the command that referenced the previously folder of the custom generated manifests: ``` kn workflow deploy --custom-manifests-dir=./manifests ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
