Copilot commented on code in PR #6393:
URL:
https://github.com/apache/incubator-kie-drools/pull/6393#discussion_r2199957380
##########
kie-dmn/kie-dmn-core/src/test/java/org/kie/dmn/core/DMNRuntimeTest.java:
##########
@@ -463,6 +462,112 @@ void boxedContext(boolean useExecModelCompiler) {
assertThat((Map<String, Object>)
dmnResult.getContext().get("Math")).containsEntry("Product",
BigDecimal.valueOf(50));
}
+ @ParameterizedTest
+ @MethodSource("params")
+ void boxedFilter(boolean useExecModelCompiler) {
+ init(useExecModelCompiler);
+ final DMNRuntime runtime =
DMNRuntimeUtil.createRuntime("valid_models/DMNv1_6/BoxedFilter.dmn",
this.getClass());
+ final DMNModel dmnModel = runtime.getModel(
+ "https://kie.org/dmn/_42BAF435-BAF7-460A-8C5D-351ABB98403C";,
+ "DMN_DFD7A647-6D67-4014-834B-E7559668C4B5"
+ );
+ assertThat(dmnModel).isNotNull();
+
assertThat(dmnModel.hasErrors()).as(DMNRuntimeUtil.formatMessages(dmnModel.getMessages())).isFalse();
+
+ final DMNContext context = DMNFactory.newContext();
+ context.set("fruit", "Mango");
+
+ final DMNResult dmnResult = runtime.evaluateAll(dmnModel, context);
+ assertThat(dmnResult).isNotNull();
+
assertThat(dmnResult.hasErrors()).as(DMNRuntimeUtil.formatMessages(dmnResult.getMessages())).isFalse();
+
assertThat(dmnResult.getContext().get("BoxedFilter")).isEqualTo(Collections.singletonList("Mango"));
+ }
+
+ @ParameterizedTest
+ @MethodSource("params")
+ void boxedFilterInvalidCondition(boolean useExecModelCompiler) {
+ init(useExecModelCompiler);
+ final DMNRuntime runtime =
DMNRuntimeUtil.createRuntime("valid_models/DMNv1_6/BoxedFilter.dmn",
this.getClass());
+ final DMNModel dmnModel = runtime.getModel(
+ "https://kie.org/dmn/_42BAF435-BAF7-460A-8C5D-351ABB98403C";,
+ "DMN_DFD7A647-6D67-4014-834B-E7559668C4B5"
+ );
+ assertThat(dmnModel).isNotNull();
+
assertThat(dmnModel.hasErrors()).as(DMNRuntimeUtil.formatMessages(dmnModel.getMessages())).isFalse();
+
+ final DMNContext context = DMNFactory.newContext();
+ context.set("fruit", "Kiwi");
+
+ final DMNResult dmnResult = runtime.evaluateAll(dmnModel, context);
+ assertThat(dmnResult).isNotNull();
+
assertThat(dmnResult.hasErrors()).as(DMNRuntimeUtil.formatMessages(dmnResult.getMessages())).isFalse();
+
assertThat(dmnResult.getContext().get("BoxedFilter")).isEqualTo(Collections.emptyList());
+ }
+
+ @ParameterizedTest
+ @MethodSource("params")
+ void boxedIterator(boolean useExecModelCompiler) {
+ init(useExecModelCompiler);
+ final DMNRuntime runtime =
DMNRuntimeUtil.createRuntime("valid_models/DMNv1_6/BoxedIterator.dmn",
this.getClass());
+ final DMNModel dmnModel = runtime.getModel(
+ "https://kie.org/dmn/_60C30701-AFB7-49C5-9B23-A0167DDC6795";,
+ "DMN_A15DEB5A-841F-4AC0-8C09-2403F5707373"
+ );
+ assertThat(dmnModel).isNotNull();
+
assertThat(dmnModel.hasErrors()).as(DMNRuntimeUtil.formatMessages(dmnModel.getMessages())).isFalse();
+
+ final DMNContext context = DMNFactory.newContext();
+ context.set("singleNumber", 5);
+ final DMNResult dmnResult = runtime.evaluateAll(dmnModel, context);
+ assertThat(dmnResult).isNotNull();
+
assertThat(dmnResult.hasErrors()).as(DMNRuntimeUtil.formatMessages(dmnResult.getMessages())).isFalse();
+
assertThat(dmnResult.getContext().get("BoxedIterator")).isEqualTo(Collections.singletonList(BigDecimal.valueOf(30)));
+ }
+
+ @ParameterizedTest
+ @MethodSource("params")
+ void boxedFilterInvalidConditionWithInvalidInput(boolean
useExecModelCompiler) {
+ init(useExecModelCompiler);
+ final DMNRuntime runtime =
DMNRuntimeUtil.createRuntime("valid_models/DMNv1_6/BoxedIterator.dmn",
this.getClass());
+ final DMNModel dmnModel = runtime.getModel(
+ "https://kie.org/dmn/_60C30701-AFB7-49C5-9B23-A0167DDC6795";,
+ "DMN_A15DEB5A-841F-4AC0-8C09-2403F5707373"
+ );
+ assertThat(dmnModel).isNotNull();
+
assertThat(dmnModel.hasErrors()).as(DMNRuntimeUtil.formatMessages(dmnModel.getMessages())).isFalse();
+
+ final DMNContext context = DMNFactory.newContext();
+ context.set("singleNumber", "invalid");
+
+ final DMNResult dmnResult = runtime.evaluateAll(dmnModel, context);
+ assertThat(dmnResult).isNotNull();
+ assertThat(dmnResult.hasErrors()).isTrue();
+ assertThat(dmnResult.getContext().get("BoxedFilter")).isNull();
Review Comment:
The assertion checks for 'BoxedFilter' but the test is using
BoxedIterator.dmn model. This should be 'BoxedIterator' to match the actual
decision being evaluated.
```suggestion
assertThat(dmnResult.getContext().get("BoxedIterator")).isNull();
```
##########
kie-dmn/kie-dmn-core/src/test/java/org/kie/dmn/core/DMNRuntimeTest.java:
##########
@@ -463,6 +462,112 @@ void boxedContext(boolean useExecModelCompiler) {
assertThat((Map<String, Object>)
dmnResult.getContext().get("Math")).containsEntry("Product",
BigDecimal.valueOf(50));
}
+ @ParameterizedTest
+ @MethodSource("params")
+ void boxedFilter(boolean useExecModelCompiler) {
+ init(useExecModelCompiler);
+ final DMNRuntime runtime =
DMNRuntimeUtil.createRuntime("valid_models/DMNv1_6/BoxedFilter.dmn",
this.getClass());
+ final DMNModel dmnModel = runtime.getModel(
+ "https://kie.org/dmn/_42BAF435-BAF7-460A-8C5D-351ABB98403C";,
+ "DMN_DFD7A647-6D67-4014-834B-E7559668C4B5"
+ );
+ assertThat(dmnModel).isNotNull();
+
assertThat(dmnModel.hasErrors()).as(DMNRuntimeUtil.formatMessages(dmnModel.getMessages())).isFalse();
+
+ final DMNContext context = DMNFactory.newContext();
+ context.set("fruit", "Mango");
+
+ final DMNResult dmnResult = runtime.evaluateAll(dmnModel, context);
+ assertThat(dmnResult).isNotNull();
+
assertThat(dmnResult.hasErrors()).as(DMNRuntimeUtil.formatMessages(dmnResult.getMessages())).isFalse();
+
assertThat(dmnResult.getContext().get("BoxedFilter")).isEqualTo(Collections.singletonList("Mango"));
+ }
+
+ @ParameterizedTest
+ @MethodSource("params")
+ void boxedFilterInvalidCondition(boolean useExecModelCompiler) {
+ init(useExecModelCompiler);
+ final DMNRuntime runtime =
DMNRuntimeUtil.createRuntime("valid_models/DMNv1_6/BoxedFilter.dmn",
this.getClass());
+ final DMNModel dmnModel = runtime.getModel(
+ "https://kie.org/dmn/_42BAF435-BAF7-460A-8C5D-351ABB98403C";,
+ "DMN_DFD7A647-6D67-4014-834B-E7559668C4B5"
+ );
+ assertThat(dmnModel).isNotNull();
+
assertThat(dmnModel.hasErrors()).as(DMNRuntimeUtil.formatMessages(dmnModel.getMessages())).isFalse();
+
+ final DMNContext context = DMNFactory.newContext();
+ context.set("fruit", "Kiwi");
+
+ final DMNResult dmnResult = runtime.evaluateAll(dmnModel, context);
+ assertThat(dmnResult).isNotNull();
+
assertThat(dmnResult.hasErrors()).as(DMNRuntimeUtil.formatMessages(dmnResult.getMessages())).isFalse();
+
assertThat(dmnResult.getContext().get("BoxedFilter")).isEqualTo(Collections.emptyList());
+ }
+
+ @ParameterizedTest
+ @MethodSource("params")
+ void boxedIterator(boolean useExecModelCompiler) {
+ init(useExecModelCompiler);
+ final DMNRuntime runtime =
DMNRuntimeUtil.createRuntime("valid_models/DMNv1_6/BoxedIterator.dmn",
this.getClass());
+ final DMNModel dmnModel = runtime.getModel(
+ "https://kie.org/dmn/_60C30701-AFB7-49C5-9B23-A0167DDC6795";,
+ "DMN_A15DEB5A-841F-4AC0-8C09-2403F5707373"
+ );
+ assertThat(dmnModel).isNotNull();
+
assertThat(dmnModel.hasErrors()).as(DMNRuntimeUtil.formatMessages(dmnModel.getMessages())).isFalse();
+
+ final DMNContext context = DMNFactory.newContext();
+ context.set("singleNumber", 5);
+ final DMNResult dmnResult = runtime.evaluateAll(dmnModel, context);
+ assertThat(dmnResult).isNotNull();
+
assertThat(dmnResult.hasErrors()).as(DMNRuntimeUtil.formatMessages(dmnResult.getMessages())).isFalse();
+
assertThat(dmnResult.getContext().get("BoxedIterator")).isEqualTo(Collections.singletonList(BigDecimal.valueOf(30)));
+ }
+
+ @ParameterizedTest
+ @MethodSource("params")
+ void boxedFilterInvalidConditionWithInvalidInput(boolean
useExecModelCompiler) {
+ init(useExecModelCompiler);
+ final DMNRuntime runtime =
DMNRuntimeUtil.createRuntime("valid_models/DMNv1_6/BoxedIterator.dmn",
this.getClass());
+ final DMNModel dmnModel = runtime.getModel(
+ "https://kie.org/dmn/_60C30701-AFB7-49C5-9B23-A0167DDC6795";,
+ "DMN_A15DEB5A-841F-4AC0-8C09-2403F5707373"
+ );
+ assertThat(dmnModel).isNotNull();
+
assertThat(dmnModel.hasErrors()).as(DMNRuntimeUtil.formatMessages(dmnModel.getMessages())).isFalse();
+
+ final DMNContext context = DMNFactory.newContext();
+ context.set("singleNumber", "invalid");
+
+ final DMNResult dmnResult = runtime.evaluateAll(dmnModel, context);
+ assertThat(dmnResult).isNotNull();
+ assertThat(dmnResult.hasErrors()).isTrue();
+ assertThat(dmnResult.getContext().get("BoxedFilter")).isNull();
+
assertThat(dmnResult.getMessages(Severity.ERROR).get(0).getMessageType()).isEqualTo(DMNMessageType.ERROR_EVAL_NODE);
+ }
+
+ @ParameterizedTest
+ @MethodSource("params")
+ void boxedFilterInvalidConditionWithNonNumeric(boolean
useExecModelCompiler) {
+ init(useExecModelCompiler);
+ final DMNRuntime runtime =
DMNRuntimeUtil.createRuntime("valid_models/DMNv1_6/BoxedIterator.dmn",
this.getClass());
+ final DMNModel dmnModel = runtime.getModel(
+ "https://kie.org/dmn/_60C30701-AFB7-49C5-9B23-A0167DDC6795";,
+ "DMN_A15DEB5A-841F-4AC0-8C09-2403F5707373"
+ );
+ assertThat(dmnModel).isNotNull();
+
assertThat(dmnModel.hasErrors()).as(DMNRuntimeUtil.formatMessages(dmnModel.getMessages())).isFalse();
+
+ final DMNContext context = DMNFactory.newContext();
+ context.set("singleNumber", List.of(1, 2, 3));
+
+ final DMNResult dmnResult = runtime.evaluateAll(dmnModel, context);
+ assertThat(dmnResult).isNotNull();
+ assertThat(dmnResult.hasErrors()).isTrue();
+ assertThat(dmnResult.getContext().get("BoxedFilter")).isNull();
Review Comment:
The assertion checks for 'BoxedFilter' but the test is using
BoxedIterator.dmn model. This should be 'BoxedIterator' to match the actual
decision being evaluated.
```suggestion
assertThat(dmnResult.getContext().get("BoxedIterator")).isNull();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
