treivize commented on PR #2215: URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2215#issuecomment-2952250934
Hello @wmedvede, Thanks for the review, you are right, it looks even simpler to even support dynamically HTTP/HTTPS directly from the HttpExecutor by changing the usage of the client.request to client.requestAbs. Looking at the implementation of this alternative method, it takes care of parsing the protocol to determine the enablement of SSL support or not. See: [WebClientBase.requestAbs()](https://github.com/vert-x3/vertx-web/blob/master/vertx-web-client/src/main/java/io/vertx/ext/web/client/impl/WebClientBase.java#L137-L146) [ClientUri.parse](https://github.com/vert-x3/vertx-web/blob/master/vertx-web-client/src/main/java/io/vertx/ext/web/client/impl/ClientUri.java#L53) I have pushed the change accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
