wmedvede commented on code in PR #3169:
URL:
https://github.com/apache/incubator-kie-tools/pull/3169#discussion_r2128336619
##########
packages/sonataflow-builder-image/resources/modules/sonataflow/builder/build-config/module.yaml:
##########
@@ -26,3 +26,5 @@ envs:
value: "false"
- name: QUARKUS_EXTENSIONS
value:
smallrye-health,org.apache.kie.sonataflow:sonataflow-quarkus:${KOGITO_VERSION},org.kie:kie-addons-quarkus-knative-eventing:${KOGITO_VERSION},org.kie:kogito-addons-quarkus-microprofile-config-service-catalog:${KOGITO_VERSION},org.kie:kie-addons-quarkus-kubernetes:${KOGITO_VERSION},org.kie:kie-addons-quarkus-events-process:${KOGITO_VERSION},org.kie:kie-addons-quarkus-process-management:${KOGITO_VERSION},org.kie:kie-addons-quarkus-source-files:${KOGITO_VERSION},org.kie:kogito-addons-quarkus-knative-serving:${KOGITO_VERSION},org.kie:kogito-addons-quarkus-jobs-knative-eventing:${KOGITO_VERSION},org.kie:kie-addons-quarkus-monitoring-prometheus:${KOGITO_VERSION},org.kie:kie-addons-quarkus-monitoring-sonataflow:${KOGITO_VERSION}
+ - name: ADDITIONAL_DEPENDENCIES
+ value:
org.kie:kie-addons-quarkus-persistence-jdbc:${KOGITO_VERSION},org.kie:kie-addons-quarkus-persistence-jdbc-deployment:${KOGITO_VERSION},io.quarkus:quarkus-jdbc-postgresql:${QUARKUS_PLATFORM_VERSION},io.quarkus:quarkus-jdbc-postgresql-deployment:${QUARKUS_PLATFORM_VERSION}
Review Comment:
The deployment artifacts of quarkus extensions are very uncommon to add at
the top level of an application, or by a regular quarkus app.
Add a comment please explaining why we need this
io.quarkus:quarkus-jdbc-postgresql:${QUARKUS_PLATFORM_VERSION} and
io.quarkus:quarkus-jdbc-postgresql-**deployment**:${QUARKUS_PLATFORM_VERSION}
otherwise I'll very difficult to remember in the future if we have issues e.g.
when changing the quarkus version, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
