oEscal commented on PR #3927: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3927#issuecomment-2931582209
> @ricardozanini @gmunozfe, can you check the contribution again? As promised, I extended the feature for the CloudEventKnativeParamsDecorator and for GET requests. As you requested, I also added some integration tests with examples. > > Some open issues: > > * As you might notice in the `queryParamsKnativeFunction.sw.json` and its test (`executeWithQueryParametersGet`), the current behavior when the developer gives `QUERY_<something>` in a GET request related step is to use that parameter name as is in the GET request. I did this as, in the Knative custom function, the developer already has a way of defining query parameters: through the arguments. However, if you think differently, I can change the code logic to remove the `QUERY_` portion of those arguments. > > * I wanted to define some integration tests with a sequence of functions, i.e., function B being executed after function A, receiving as arguments the outputs of the previous function. However, I could not find a way to do this. Do you have any examples of how to achieve this? How do I create a stub for both functions in that case? @ricardozanini @gmunozfe It seems the checks are now successful (except for the one related to Keycloak). Now, there are still these two points before merging. What is your take on them? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
