Kusuma04-dev commented on PR #3155: URL: https://github.com/apache/incubator-kie-tools/pull/3155#issuecomment-2909733477
> Thanks for the PR, @Kusuma04-dev. I have some reviews on it. > > 1. Right now, For me personally it’s a bit confusing to understand which class names here have conflicts with internal and which ones have conflicts with external for the first time. Perhaps we could add a label as a prefix to the external conflicts class, similar to how we display the list of DMN datatypes in editors. Please refer to the screenshot below for your reference. Let me know your thoughts or if you have better representations. > >  > > 2. Once we have conflicts with external data types, we disable the replace radio button. In such cases, it might be a good idea to default to selecting the “Keep Both” radio button. This way, users don’t have to manually do additional sections in the UI. They can simply click on the import button. From the screenshot, I can see that the replace option is currently selected by default. WDYT? @jomarko WDYT on showing label while searching? I feel as we are already mentioning external types in popup. So do we still need this label? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
