Copilot commented on code in PR #2103: URL: https://github.com/apache/incubator-kie-kogito-examples/pull/2103#discussion_r2099677969
########## kogito-springboot-examples/rules-legacy-scesim-springboot-example/src/test/java/testscenario/TestScenarioJunitActivatorTest.java: ########## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package testscenario; + +import org.drools.scenariosimulation.backend.runner.TestScenarioActivator; + +/** + * TestScenarioJunitActivator is a custom JUnit runner that enables the execution of Test Scenario files (*.scesim). + * This activator class, when executed, will load all scesim files available in the project and run them. + * Each row of the scenario will generate a test JUnit result. Review Comment: [nitpick] Revise the Javadoc to describe this test class itself (e.g., `TestScenarioJunitActivatorTest`) and its use of `@TestScenarioActivator`, rather than naming the runner. For example: "This test class uses `@TestScenarioActivator` to execute all `.scesim` scenarios." ```suggestion * This test class uses the {@link TestScenarioActivator} annotation to execute all Test Scenario files (*.scesim). * When executed, it loads all available `.scesim` files in the project and runs them as test scenarios. * Each row in a scenario file corresponds to a test case, and the results are reported as JUnit test results. ``` ########## kogito-springboot-examples/dmn-pmml-springboot-example/src/test/java/testscenario/TestScenarioJunitActivatorTest.java: ########## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package testscenario; + +import org.drools.scenariosimulation.backend.runner.TestScenarioActivator; + +/** + * TestScenarioJunitActivator is a custom JUnit runner that enables the execution of Test Scenario files (*.scesim). Review Comment: [nitpick] Align the Javadoc with the test class (`TestScenarioJunitActivatorTest`) and its use of `@TestScenarioActivator`, or use a generic summary to avoid mismatches. ########## kogito-quarkus-examples/dmn-resource-jar-quarkus-example/dmn-quarkus-consumer-example/src/test/java/testscenario/TestScenarioJunitActivatorTest.java: ########## @@ -18,12 +18,14 @@ */ package testscenario; +import org.drools.scenariosimulation.backend.runner.TestScenarioActivator; + /** - * KogitoJunitActivator is a custom JUnit runner that enables the execution of Test Scenario files (*.scesim). + * TestScenarioJunitActivator is a custom JUnit runner that enables the execution of Test Scenario files (*.scesim). Review Comment: [nitpick] Update the Javadoc to reference the test class name (`TestScenarioJunitActivatorTest`) or use a neutral description, since it no longer directly names the runner. ########## kogito-quarkus-examples/dmn-multiple-models-quarkus-example/src/test/java/testscenario/TestScenarioJunitActivatorTest.java: ########## @@ -18,12 +18,14 @@ */ package testscenario; +import org.drools.scenariosimulation.backend.runner.TestScenarioActivator; + /** - * KogitoJunitActivator is a custom JUnit runner that enables the execution of Test Scenario files (*.scesim). + * TestScenarioJunitActivator is a custom JUnit runner that enables the execution of Test Scenario files (*.scesim). Review Comment: [nitpick] The Javadoc should reflect the actual test class (`TestScenarioJunitActivatorTest`) rather than naming the runner; consider a generic description of its annotation-driven behavior. ########## kogito-quarkus-examples/rules-legacy-scesim-quarkus-example/src/test/java/testscenario/TestScenarioJunitActivatorTest.java: ########## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package testscenario; + +import org.drools.scenariosimulation.backend.runner.TestScenarioActivator; + +/** + * TestScenarioJunitActivator is a custom JUnit runner that enables the execution of Test Scenario files (*.scesim). Review Comment: [nitpick] The Javadoc currently names the runner class rather than the test class. Consider describing the test class’s role with `@TestScenarioActivator` to keep docs accurate. ########## kogito-springboot-examples/dmn-springboot-example/src/test/java/testscenario/TestScenarioJunitActivatorTest.java: ########## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package testscenario; + +import org.drools.scenariosimulation.backend.runner.TestScenarioActivator; + +/** + * TestScenarioJunitActivator is a custom JUnit runner that enables the execution of Test Scenario files (*.scesim). + * This activator class, when executed, will load all scesim files available in the project and run them. + * Each row of the scenario will generate a test JUnit result. Review Comment: [nitpick] Update the class Javadoc to reflect that `TestScenarioJunitActivatorTest` leverages the `@TestScenarioActivator` annotation, rather than naming the runner class. A generic description would avoid confusion. ```suggestion * TestScenarioJunitActivatorTest leverages the @TestScenarioActivator annotation to enable the execution of Test Scenario files (*.scesim). * When executed, this class will load all scesim files available in the project and run them. * Each row of the scenario will generate a test result. ``` ########## kogito-quarkus-examples/dmn-pmml-quarkus-example/src/test/java/testscenario/TestScenarioJunitActivatorTest.java: ########## @@ -18,12 +18,14 @@ */ package testscenario; +import org.drools.scenariosimulation.backend.runner.TestScenarioActivator; + /** - * KogitoJunitActivator is a custom JUnit runner that enables the execution of Test Scenario files (*.scesim). + * TestScenarioJunitActivator is a custom JUnit runner that enables the execution of Test Scenario files (*.scesim). Review Comment: [nitpick] Align the Javadoc description to match the test class name (`TestScenarioJunitActivatorTest`) or opt for a non-specific description of its use of `@TestScenarioActivator`. ########## kogito-quarkus-examples/dmn-quarkus-example/src/test/java/testscenario/TestScenarioJunitActivatorTest.java: ########## @@ -18,12 +18,14 @@ */ package testscenario; +import org.drools.scenariosimulation.backend.runner.TestScenarioActivator; + /** - * KogitoJunitActivator is a custom JUnit runner that enables the execution of Test Scenario files (*.scesim). + * TestScenarioJunitActivator is a custom JUnit runner that enables the execution of Test Scenario files (*.scesim). Review Comment: [nitpick] Consider revising the Javadoc to describe this test class’s purpose with `@TestScenarioActivator` instead of naming the runner directly, to avoid confusion. ########## kogito-springboot-examples/dmn-resource-jar-springboot-example/dmn-springboot-consumer-example/src/test/java/testscenario/TestScenarioJunitActivatorTest.java: ########## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package testscenario; + +import org.drools.scenariosimulation.backend.runner.TestScenarioActivator; + +/** + * TestScenarioJunitActivator is a custom JUnit runner that enables the execution of Test Scenario files (*.scesim). Review Comment: [nitpick] The Javadoc still refers to `TestScenarioJunitActivator` but the test class is named `TestScenarioJunitActivatorTest`. Consider making the description class-name-agnostic or matching the actual class name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
