thiagoelg commented on code in PR #3042:
URL:
https://github.com/apache/incubator-kie-tools/pull/3042#discussion_r2093719752
##########
packages/dev-deployment-dmn-form-webapp/src/DmnDevDeploymentFormWebAppDataApi.tsx:
##########
@@ -46,11 +52,14 @@ export async function fetchAppData(args: {
quarkusAppOrigin: string; quarkusAppP
// Beyond that, we want to delete these paths from the openApiSpec to avoid
trying to
// dereferencing them.
Object.keys(openApiSpec.paths).forEach((modelPath) => {
+ // Remove any route that doesn't have a respective `/dmnresult` route.
if (
!modelPath.endsWith("/dmnresult") &&
+ !dmnResultPaths.has(`${modelPath}/dmnresult`) &&
!Object.keys(openApiSpec.paths).find((path) => path ===
`${modelPath}/dmnresult`)
) {
delete openApiSpec.paths?.[modelPath];
+ delete openApiSpec.paths[modelPath];
Review Comment:
Looks like you applied the same fix that I did here, but a bit different:
https://github.com/apache/incubator-kie-tools/pull/3094/files#diff-52f209736b9bb9a37745daa4ed3ed682de196bea4fd4cda22284983b20347e67R51
Feel free to keep whichever you prefer. They both seem to do the same thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
