gitgabrio commented on code in PR #3868:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3868#discussion_r2079632007
##########
springboot/addons/explainability/src/main/java/org/kie/kogito/explainability/SpringBootExplainableResource.java:
##########
@@ -52,7 +52,7 @@ public ResponseEntity predict(@RequestBody List<PredictInput>
inputs) {
return
ResponseEntity.ok(explainabilityService.processRequest(application, inputs));
} catch (Exception e) {
LOGGER.warn("An Exception occurred processing the predict
request", e);
- return ResponseEntity.badRequest().body(e.getMessage());
+ return ResponseEntity.badRequest().body("Invalid request data.");
Review Comment:
Please restore the original logic. Eventually, introduce a check on
`e.getMessage() == null`- but this copletely hide real issue to caller code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
