This is an automated email from the ASF dual-hosted git repository.
tkobayas pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-kie-drools.git
The following commit(s) were added to refs/heads/main by this push:
new 5a378a9b71 [NO-ISSUE] Fix KieRepositoryTest (#6328) (#6329)
5a378a9b71 is described below
commit 5a378a9b71827fa8cda4d499929c118131a4613f
Author: Toshiya Kobayashi <[email protected]>
AuthorDate: Fri May 2 17:14:51 2025 +0900
[NO-ISSUE] Fix KieRepositoryTest (#6328) (#6329)
---
drools-test-coverage/drools-test-coverage-jars/README.md | 4 ++--
.../src/it}/only-jar-pojo-not-kjar-no-kmodule/pom.xml | 4 +---
.../integrationtests/only_jar_pojo_not_kjar_no_kmodule/MyPojo.java | 0
drools-test-coverage/drools-test-coverage-jars/pom.xml | 1 -
4 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/drools-test-coverage/drools-test-coverage-jars/README.md
b/drools-test-coverage/drools-test-coverage-jars/README.md
index 195a5f7d59..4ee66cda9f 100644
--- a/drools-test-coverage/drools-test-coverage-jars/README.md
+++ b/drools-test-coverage/drools-test-coverage-jars/README.md
@@ -21,8 +21,8 @@
This project is to build jars that are used in `drools-test-coverage` project.
So we can avoid having jar binaries in the codebase.
### How to add a jar project
-If the jar is not a kjar, you can simply add the jar project under this
project. `surf` project is an example.
+If the jar is not a kjar and doesn't care about the artifact version, you can
simply add the jar project under this project. `surf` project is an example.
When copying the jar file, you should not include its artifact version in its
destination file name in order to avoid a test failure when upgrading drools
version.
-If the jar has a fixed version while requires the current version for
dependency or plugin (e.g. jar version is `1.0.0`, but requires `999-SNAPSHOT`
kie-maven-plugin to build the kjar), use
`drools-test-coverage-jars-with-invoker` to build the jar with
maven-invoker-plugin. Place the jar project under `src/it`. `kie-poject-simple`
is an example.
+If the jar has a fixed version while requires the current version for
dependency or plugin (e.g. jar version is `1.0.0`, but requires `999-SNAPSHOT`
kie-maven-plugin to build the kjar), use
`drools-test-coverage-jars-with-invoker` to build the jar with
maven-invoker-plugin. Place the jar project under `src/it`. `kie-poject-simple`
is an example. Even if the jar is not a kjar, you would need to use
`drools-test-coverage-jars-with-invoker` to build the jar to have a fixed
version (e.g. `on [...]
In both cases, you would need to copy the jar file to the target test project
using `copy-rename-maven-plugin`.
\ No newline at end of file
diff --git
a/drools-test-coverage/drools-test-coverage-jars/only-jar-pojo-not-kjar-no-kmodule/pom.xml
b/drools-test-coverage/drools-test-coverage-jars/drools-test-coverage-jars-with-invoker/src/it/only-jar-pojo-not-kjar-no-kmodule/pom.xml
similarity index 93%
rename from
drools-test-coverage/drools-test-coverage-jars/only-jar-pojo-not-kjar-no-kmodule/pom.xml
rename to
drools-test-coverage/drools-test-coverage-jars/drools-test-coverage-jars-with-invoker/src/it/only-jar-pojo-not-kjar-no-kmodule/pom.xml
index 743140ddc6..0edbc852bf 100644
---
a/drools-test-coverage/drools-test-coverage-jars/only-jar-pojo-not-kjar-no-kmodule/pom.xml
+++
b/drools-test-coverage/drools-test-coverage-jars/drools-test-coverage-jars-with-invoker/src/it/only-jar-pojo-not-kjar-no-kmodule/pom.xml
@@ -28,8 +28,6 @@
<version>1.0.0</version>
<packaging>jar</packaging>
- <name>Drools :: Test Coverage :: Jar without kmodule.xml</name>
-
<properties>
<java.module.name>org.drools.compiler.integrationtests.only.jar.pojo.not.kjar.no.kmodule</java.module.name>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
@@ -64,7 +62,7 @@
</goals>
<configuration>
<sourceFile>${project.build.directory}/${project.build.finalName}.jar</sourceFile>
-
<destinationFile>${project.build.directory}/../../../test-compiler-integration/src/test/resources/${project.artifactId}-${project.version}.jar</destinationFile>
+
<destinationFile>${project.build.directory}/../../../../../../test-compiler-integration/src/test/resources/${project.artifactId}-${project.version}.jar</destinationFile>
</configuration>
</execution>
</executions>
diff --git
a/drools-test-coverage/drools-test-coverage-jars/only-jar-pojo-not-kjar-no-kmodule/src/main/java/org/drools/compiler/integrationtests/only_jar_pojo_not_kjar_no_kmodule/MyPojo.java
b/drools-test-coverage/drools-test-coverage-jars/drools-test-coverage-jars-with-invoker/src/it/only-jar-pojo-not-kjar-no-kmodule/src/main/java/org/drools/compiler/integrationtests/only_jar_pojo_not_kjar_no_kmodule/MyPojo.java
similarity index 100%
rename from
drools-test-coverage/drools-test-coverage-jars/only-jar-pojo-not-kjar-no-kmodule/src/main/java/org/drools/compiler/integrationtests/only_jar_pojo_not_kjar_no_kmodule/MyPojo.java
rename to
drools-test-coverage/drools-test-coverage-jars/drools-test-coverage-jars-with-invoker/src/it/only-jar-pojo-not-kjar-no-kmodule/src/main/java/org/drools/compiler/integrationtests/only_jar_pojo_not_kjar_no_kmodule/MyPojo.java
diff --git a/drools-test-coverage/drools-test-coverage-jars/pom.xml
b/drools-test-coverage/drools-test-coverage-jars/pom.xml
index 57f498e6e3..c32590b146 100644
--- a/drools-test-coverage/drools-test-coverage-jars/pom.xml
+++ b/drools-test-coverage/drools-test-coverage-jars/pom.xml
@@ -41,7 +41,6 @@
<modules>
<module>surf</module>
<module>testEnum</module>
- <module>only-jar-pojo-not-kjar-no-kmodule</module>
<module>setter-overload</module>
<module>drools-test-coverage-jars-with-invoker</module>
</modules>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
