tkobayas commented on issue #6309:
URL: 
https://github.com/apache/incubator-kie-drools/issues/6309#issuecomment-2812413276

   > Is it possible to make collectResourcesInJar and/or 
ruleResourcesForUnitClass protected? It is private now and I actually have to 
copy paste most of the RuleUnitProviderImpl?
   
   It sounds reasonable. I will change it, too.
   
   > P.S. why such a name? RuleUnitProviderImpl
   > Is that considered as a naming anti-pattern?
   
   I'm not very opinionated. I agree that "DefaultRuleUnitProvider" may be 
better.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to