[karaf] branch karaf-4.3.x updated: [KARAF-6074] Prevent duplicate PIDs from factory PID defined in feature config

[jbonofre]

This is an automated email from the ASF dual-hosted git repository.

jbonofre pushed a commit to branch karaf-4.3.x
in repository https://gitbox.apache.org/repos/asf/karaf.git


The following commit(s) were added to refs/heads/karaf-4.3.x by this push:
     new 7343183127 [KARAF-6074] Prevent duplicate PIDs from factory PID 
defined in feature config
7343183127 is described below

commit 73431831273b1e3383d9885ac36945126645e011
Author: Grzegorz Grzybek <ggrzy...@redhat.com>
AuthorDate: Thu Jun 1 11:48:14 2023 +0200

    [KARAF-6074] Prevent duplicate PIDs from factory PID defined in feature 
config
    
    (cherry picked from commit f5ee79652dfc3f8d8c25620abce60910b63c55da)
---
 .../karaf/features/internal/service/FeatureConfigInstaller.java       | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git 
a/features/core/src/main/java/org/apache/karaf/features/internal/service/FeatureConfigInstaller.java
 
b/features/core/src/main/java/org/apache/karaf/features/internal/service/FeatureConfigInstaller.java
index a4e99668f6..7d530ae4e6 100644
--- 
a/features/core/src/main/java/org/apache/karaf/features/internal/service/FeatureConfigInstaller.java
+++ 
b/features/core/src/main/java/org/apache/karaf/features/internal/service/FeatureConfigInstaller.java
@@ -68,9 +68,7 @@ public class FeatureConfigInstaller {
         if (n > 0) {
             cid.isFactoryPid = true;
             cid.factoryPid = pid.substring(0, n);
-            if (pid.contains("~")) {
-                cid.name = pid.substring(n + 1);
-            }
+            cid.name = pid.substring(n + 1);
         }
         return cid;
     }