This is an automated email from the ASF dual-hosted git repository.
chia7712 pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new 81460c8245d KAFKA-20546 Lazily call generateNewClientId when handling
GetTelemetrySubscriptionsRequest (#22206)
81460c8245d is described below
commit 81460c8245ddd5f0034ece00780ce35743f4f484
Author: Bolin Lin <[email protected]>
AuthorDate: Tue May 5 12:41:02 2026 -0400
KAFKA-20546 Lazily call generateNewClientId when handling
GetTelemetrySubscriptionsRequest (#22206)
Generate new client id only when id does not exist with lazy evaluation
Reviewers: Chia-Ping Tsai <[email protected]>
---
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java
b/server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java
index c8e01502ed1..9ddbf2cc76b 100644
--- a/server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java
+++ b/server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java
@@ -162,7 +162,7 @@ public class ClientMetricsManager implements AutoCloseable {
long now = time.milliseconds();
Uuid clientInstanceId =
Optional.ofNullable(request.data().clientInstanceId())
.filter(id -> !id.equals(Uuid.ZERO_UUID))
- .orElse(generateNewClientId());
+ .orElseGet(this::generateNewClientId);
/*
Get the client instance from the cache or create a new one. If
subscription has changed