This is an automated email from the ASF dual-hosted git repository.
mjsax pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new 4bb8f0fd01e MINOR: Fix duplicate args in
KStreamSessionWindowAggregateProcessorTest (#22183)
4bb8f0fd01e is described below
commit 4bb8f0fd01e841b775e9037eb5c3960198c89e17
Author: Alieh Saeedi <[email protected]>
AuthorDate: Thu Apr 30 05:39:24 2026 +0200
MINOR: Fix duplicate args in KStreamSessionWindowAggregateProcessorTest
(#22183)
The `emitStrategyAndHeadersMatrix()` currently returns four entries but
they are duplicates of ON_WINDOW_UPDATE (and therefore also runs each
case twice). This also drops coverage for
EmitStrategy.StrategyType.ON_WINDOW_CLOSE, which was previously covered
via @EnumSource. Update the method source to generate the full matrix of
strategy type(s) and withHeaders values (eg, include both
ON_WINDOW_UPDATE and ON_WINDOW_CLOSE, each with withHeaders=false/true)
without duplicates.
Reviewers: Murali Basani <[email protected]>, Matthias J. Sax
<[email protected]>
---
.../kstream/internals/KStreamSessionWindowAggregateProcessorTest.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
a/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSessionWindowAggregateProcessorTest.java
b/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSessionWindowAggregateProcessorTest.java
index 25d1774705c..d0a71c63280 100644
---
a/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSessionWindowAggregateProcessorTest.java
+++
b/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSessionWindowAggregateProcessorTest.java
@@ -105,8 +105,8 @@ public class KStreamSessionWindowAggregateProcessorTest {
return Stream.of(
Arguments.of(EmitStrategy.StrategyType.ON_WINDOW_UPDATE, true),
Arguments.of(EmitStrategy.StrategyType.ON_WINDOW_UPDATE, false),
- Arguments.of(EmitStrategy.StrategyType.ON_WINDOW_UPDATE, true),
- Arguments.of(EmitStrategy.StrategyType.ON_WINDOW_UPDATE, false)
+ Arguments.of(EmitStrategy.StrategyType.ON_WINDOW_CLOSE, true),
+ Arguments.of(EmitStrategy.StrategyType.ON_WINDOW_CLOSE, false)
);
}