(kafka) branch trunk updated: KAFKA-20182 Remove removeUnusedImports and upgrade spotless to 8.4.0 (#22025)

[chia7712]

This is an automated email from the ASF dual-hosted git repository.

chia7712 pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 2327e51926d KAFKA-20182 Remove removeUnusedImports and upgrade 
spotless to 8.4.0 (#22025)
2327e51926d is described below

commit 2327e51926d666d979f8363dedf0894390430a7c
Author: Ming-Yen Chung <mingyen...@gmail.com>
AuthorDate: Tue Apr 14 13:52:40 2026 +0800

    KAFKA-20182 Remove removeUnusedImports and upgrade spotless to 8.4.0 
(#22025)
    
    Follow-up to #22012. Removes removeUnusedImports because its engines
    (google-java-format, cleanthat) can non-deterministically throw
    InvocationTargetException under parallel execution (see
    https://github.com/diffplug/spotless/issues/2850 for a similar report).
    Unused imports are still enforced by checkstyle (UnusedImports +
    RedundantImport).
    
    Also bumps Spotless from 8.3.0 to 8.4.0.
    
    Verified locally:
    - `./gradlew build -x test` passes (spotlessCheck + checkstyle +
    spotbugs + compile all green)
    - `./gradlew clean spotlessApply --rerun-tasks --no-build-cache` ran 700
    times with 0 failures
    
    Reviewers: Chia-Ping Tsai <chia7...@gmail.com>
---
 build.gradle | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/build.gradle b/build.gradle
index 6570cd7bbb2..2e4068391d2 100644
--- a/build.gradle
+++ b/build.gradle
@@ -40,7 +40,7 @@ plugins {
   id "com.github.spotbugs" version '6.4.4' apply false
   id 'org.scoverage' version '8.1' apply false
   id 'com.gradleup.shadow' version '9.3.1' apply false
-  id 'com.diffplug.spotless' version "8.3.0"
+  id 'com.diffplug.spotless' version "8.4.0"
 }
 
 ext {
@@ -871,14 +871,11 @@ subprojects {
     java {
       targetExclude('**/generated/**/*.java','**/generated-test/**/*.java')
       importOrder('kafka', 'org.apache.kafka', 'com', 'net', 'org', 'java', 
'javax', '', '\\#')
-      // The default engine (google-java-format) uses the JDK compiler's 
internal
-      // parser (com.sun.tools.javac.*), which JPMS blocks without 
--add-exports.
-      // Gradle 9.3+ / Spotless 8.x no longer pass those exports to the worker 
JVM,
-      // so the default engine fails at runtime. The cleanthat engine uses the
-      // JavaParser library instead, which ships its own Java parser and does 
not
-      // rely on any JDK internal classes, so it works out of the box.
-      // See KAFKA-20182.
-      removeUnusedImports('cleanthat-javaparser-unnecessaryimport')
+      // removeUnusedImports is intentionally omitted because its engines
+      // (google-java-format, cleanthat) can non-deterministically throw
+      // InvocationTargetException under parallel execution. Unused imports are
+      // still enforced by checkstyle (UnusedImports + RedundantImport).
+      // Re-enable once https://github.com/diffplug/spotless/issues/2850 is 
fixed.
     }
   }