This is an automated email from the ASF dual-hosted git repository.
mimaison pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new e30f771d368 MINOR: Code cleanup in server module (#22026)
e30f771d368 is described below
commit e30f771d3689dec880e5bdbacb0a84bd7c24bd97
Author: nileshkumar3 <[email protected]>
AuthorDate: Mon Apr 13 09:06:16 2026 -0500
MINOR: Code cleanup in server module (#22026)
Fix no-op String.join and Javadoc
Reviewers: Mickael Maison <[email protected]>
---
server/src/main/java/org/apache/kafka/server/FetchSession.java | 2 +-
.../src/main/java/org/apache/kafka/server/FetchSessionCacheShard.java | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/server/src/main/java/org/apache/kafka/server/FetchSession.java
b/server/src/main/java/org/apache/kafka/server/FetchSession.java
index db4af175c80..adff78c4e92 100644
--- a/server/src/main/java/org/apache/kafka/server/FetchSession.java
+++ b/server/src/main/java/org/apache/kafka/server/FetchSession.java
@@ -90,7 +90,7 @@ public class FetchSession {
static String partitionsToLogString(Collection<TopicIdPartition>
partitions, boolean traceEnabled) {
return traceEnabled
- ? "(" + String.join(", ", partitions.toString()) + ")"
+ ? partitions.toString()
: partitions.size() + " partition(s)";
}
diff --git
a/server/src/main/java/org/apache/kafka/server/FetchSessionCacheShard.java
b/server/src/main/java/org/apache/kafka/server/FetchSessionCacheShard.java
index fd59b0ca1a3..a77148956be 100644
--- a/server/src/main/java/org/apache/kafka/server/FetchSessionCacheShard.java
+++ b/server/src/main/java/org/apache/kafka/server/FetchSessionCacheShard.java
@@ -118,7 +118,7 @@ public class FetchSessionCacheShard {
* Get a session by session ID.
*
* @param sessionId The session ID.
- * @return The session, or None if no such session was found.
+ * @return The session, or an empty Optional if no such session
was found.
*/
synchronized Optional<FetchSession> get(int sessionId) {
return Optional.ofNullable(sessions.get(sessionId));
@@ -243,7 +243,7 @@ public class FetchSessionCacheShard {
*
* @param session The session.
*
- * @return The removed session, or None if there was no such
session.
+ * @return The removed session, or an empty Optional if there was
no such session.
*/
synchronized Optional<FetchSession> remove(FetchSession session) {
EvictableKey evictableKey;