(kafka) branch trunk updated: KAFKA-20405: Remove redundant `numClassicGroupsTimelineCounter` (#21978)

[dajac]

This is an automated email from the ASF dual-hosted git repository.

dajac pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 69d5456ecea KAFKA-20405: Remove redundant 
`numClassicGroupsTimelineCounter` (#21978)
69d5456ecea is described below

commit 69d5456eceaa1e1e75c071dd3d1338a96a692975
Author: Nick Guo <lansg0...@gmail.com>
AuthorDate: Tue Apr 7 19:35:34 2026 +0800

    KAFKA-20405: Remove redundant `numClassicGroupsTimelineCounter` (#21978)
    
    The `numClassicGroupsTimelineCounter` is currently redundant.   The same
    metric tracking is already being handled effectively with
    
    
[`GroupCoordinatorMetricsShard#numClassicGroups`](https://github.com/apache/kafka/blob/7b8549f3c4cc26fd2153ef024c2fb743cfe83461/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorMetricsShard.java#L189).
    
    Reviewers: Sean Quah <sq...@confluent.io>, David Jacot
    <dja...@confluent.io>
---
 .../group/metrics/GroupCoordinatorMetricsShard.java            | 10 ----------
 1 file changed, 10 deletions(-)

diff --git 
a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorMetricsShard.java
 
b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorMetricsShard.java
index f2f7fb2ced7..6dc8c6b3305 100644
--- 
a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorMetricsShard.java
+++ 
b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorMetricsShard.java
@@ -79,10 +79,6 @@ public class GroupCoordinatorMetricsShard implements 
CoordinatorMetricsShard {
      */
     private final TimelineGaugeCounter numOffsetsTimelineGaugeCounter;
 
-    /**
-     * The number of classic groups metric counter.
-     */
-    private final TimelineGaugeCounter numClassicGroupsTimelineCounter;
 
     /**
      * The topic partition.
@@ -96,7 +92,6 @@ public class GroupCoordinatorMetricsShard implements 
CoordinatorMetricsShard {
     ) {
         Objects.requireNonNull(snapshotRegistry);
         numOffsetsTimelineGaugeCounter = new TimelineGaugeCounter(new 
TimelineLong(snapshotRegistry), new AtomicLong(0));
-        numClassicGroupsTimelineCounter = new TimelineGaugeCounter(new 
TimelineLong(snapshotRegistry), new AtomicLong(0));
 
         this.classicGroupGauges = Map.of();
         this.consumerGroupGauges = Map.of();
@@ -283,11 +278,6 @@ public class GroupCoordinatorMetricsShard implements 
CoordinatorMetricsShard {
 
     @Override
     public void commitUpTo(long offset) {
-        synchronized (numClassicGroupsTimelineCounter.timelineLong) {
-            long value = 
numClassicGroupsTimelineCounter.timelineLong.get(offset);
-            numClassicGroupsTimelineCounter.atomicLong.set(value);
-        }
-
         synchronized (numOffsetsTimelineGaugeCounter.timelineLong) {
             long value = 
numOffsetsTimelineGaugeCounter.timelineLong.get(offset);
             numOffsetsTimelineGaugeCounter.atomicLong.set(value);