This is an automated email from the ASF dual-hosted git repository.
frankvicky pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new 82869a77bb6 MINOR: Add todo to WindowSegmentWithHeaders (#21917)
82869a77bb6 is described below
commit 82869a77bb68a6f40e3111e69834423f1a8d6c99
Author: PoAn Yang <[email protected]>
AuthorDate: Thu Apr 2 17:42:24 2026 +0900
MINOR: Add todo to WindowSegmentWithHeaders (#21917)
Current implementation format for WindowSegmentWithHeaders and
RocksDBMigratingWindowStoreWithHeaders is
`[headersSize(varint)][headersBytes][timestamp(8)][value]`. Add todo to
mention the expected format will be achieved in KAFKA-20334.
Reviewers: TengYao Chi <[email protected]>
Signed-off-by: PoAn Yang <[email protected]>
---
.../streams/state/internals/RocksDBMigratingWindowStoreWithHeaders.java | 2 ++
.../apache/kafka/streams/state/internals/WindowSegmentWithHeaders.java | 2 ++
2 files changed, 4 insertions(+)
diff --git
a/streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBMigratingWindowStoreWithHeaders.java
b/streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBMigratingWindowStoreWithHeaders.java
index 0ca73a25676..1ee56dd2c49 100644
---
a/streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBMigratingWindowStoreWithHeaders.java
+++
b/streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBMigratingWindowStoreWithHeaders.java
@@ -44,6 +44,8 @@ import java.util.List;
* <li>New format (HEADERS CF): {@code
[headersSize(varint)][headersBytes][value]}</li>
* </ul>
* <p>
+ * TODO: Current format is {@code
[headersSize(varint)][headersBytes][timestamp(8)][value]}.
+ * The new format will be introduced in KAFKA-20334.
* This is similar to {@link RocksDBMigratingSessionStoreWithHeaders} but for
window stores.
* Unlike timestamped stores, window stores don't include timestamp in the
value (it's in the key).
*/
diff --git
a/streams/src/main/java/org/apache/kafka/streams/state/internals/WindowSegmentWithHeaders.java
b/streams/src/main/java/org/apache/kafka/streams/state/internals/WindowSegmentWithHeaders.java
index 468afd827a4..740e7647d89 100644
---
a/streams/src/main/java/org/apache/kafka/streams/state/internals/WindowSegmentWithHeaders.java
+++
b/streams/src/main/java/org/apache/kafka/streams/state/internals/WindowSegmentWithHeaders.java
@@ -38,6 +38,8 @@ import java.util.Objects;
* <li>Old format (DEFAULT CF): {@code [value]}</li>
* <li>New format (HEADERS CF): {@code
[headersSize(varint)][headersBytes][value]}</li>
* </ul>
+ * TODO: Current format is {@code
[headersSize(varint)][headersBytes][timestamp(8)][value]}.
+ * The new format will be introduced in KAFKA-20334.
*/
class WindowSegmentWithHeaders extends RocksDBMigratingWindowStoreWithHeaders
implements Segment {
