This is an automated email from the ASF dual-hosted git repository.
mjsax pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new 56d562d4b3e KAFKA-20258 Refactor DSL store config and propagate
dslStoreFormat (#21784)
56d562d4b3e is described below
commit 56d562d4b3e99a0e7847d33b97420630eef7dee7
Author: Zheguang Zhao <[email protected]>
AuthorDate: Thu Mar 19 06:19:41 2026 +1100
KAFKA-20258 Refactor DSL store config and propagate dslStoreFormat (#21784)
This patch removes dead code `isTimeStamped`.
Reviewers: Alieh Saeedi <[email protected]>, Matthias J. Sax
<[email protected]>
---
.../org/apache/kafka/streams/state/DslKeyValueParams.java | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git
a/streams/src/main/java/org/apache/kafka/streams/state/DslKeyValueParams.java
b/streams/src/main/java/org/apache/kafka/streams/state/DslKeyValueParams.java
index 73258fe59b4..3bf696761fb 100644
---
a/streams/src/main/java/org/apache/kafka/streams/state/DslKeyValueParams.java
+++
b/streams/src/main/java/org/apache/kafka/streams/state/DslKeyValueParams.java
@@ -27,7 +27,6 @@ import java.util.Objects;
public class DslKeyValueParams {
private final String name;
- private final boolean isTimestamped;
private final DslStoreFormat dslStoreFormat;
/**
@@ -39,7 +38,6 @@ public class DslKeyValueParams {
public DslKeyValueParams(final String name, final boolean isTimestamped) {
Objects.requireNonNull(name);
this.name = name;
- this.isTimestamped = isTimestamped;
// If isTimestamped is false and the user is still calling the old
deprecated constructor, we should assume they mean plain.
this.dslStoreFormat = isTimestamped ? DslStoreFormat.TIMESTAMPED :
DslStoreFormat.PLAIN;
}
@@ -51,7 +49,6 @@ public class DslKeyValueParams {
public DslKeyValueParams(final String name, final DslStoreFormat
dslStoreFormat) {
this.name = Objects.requireNonNull(name);
this.dslStoreFormat = Objects.requireNonNull(dslStoreFormat);
- this.isTimestamped = dslStoreFormat == DslStoreFormat.TIMESTAMPED;
}
public String name() {
@@ -85,22 +82,20 @@ public class DslKeyValueParams {
return false;
}
final DslKeyValueParams that = (DslKeyValueParams) o;
- return isTimestamped == that.isTimestamped
- && dslStoreFormat == that.dslStoreFormat
+ return dslStoreFormat == that.dslStoreFormat
&& Objects.equals(name, that.name);
}
@Override
public int hashCode() {
- return Objects.hash(name, isTimestamped, dslStoreFormat);
+ return Objects.hash(name, dslStoreFormat);
}
@Override
public String toString() {
return "DslKeyValueParams{" +
"name='" + name + '\'' +
- "isTimestamped=" + isTimestamped +
"dslStoreFormat=" + dslStoreFormat +
'}';
}
-}
\ No newline at end of file
+}