(kafka) branch trunk updated: MINOR: Update testIdleTimeCallback in KafkaEventQueueTest (#20798)

[chia7712]

This is an automated email from the ASF dual-hosted git repository.

chia7712 pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 346cf129e42 MINOR: Update testIdleTimeCallback in KafkaEventQueueTest 
(#20798)
346cf129e42 is described below

commit 346cf129e42624fc5c9c0296f641add3c5b968ed
Author: Mahsa Seifikar <mseifi...@confluent.io>
AuthorDate: Fri Oct 31 08:22:33 2025 -0400

    MINOR: Update testIdleTimeCallback in KafkaEventQueueTest (#20798)
    
    This PR addresses [this
    
    
feedback](https://github.com/apache/kafka/pull/20724#discussion_r2475126513).
    
    Reviewers: Chia-Ping Tsai <chia7...@gmail.com>
---
 .../test/java/org/apache/kafka/queue/KafkaEventQueueTest.java  | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git 
a/server-common/src/test/java/org/apache/kafka/queue/KafkaEventQueueTest.java 
b/server-common/src/test/java/org/apache/kafka/queue/KafkaEventQueueTest.java
index 41972f9fb44..893ef4ba9f5 100644
--- 
a/server-common/src/test/java/org/apache/kafka/queue/KafkaEventQueueTest.java
+++ 
b/server-common/src/test/java/org/apache/kafka/queue/KafkaEventQueueTest.java
@@ -429,13 +429,17 @@ public class KafkaEventQueueTest {
     public void testIdleTimeCallback() throws Exception {
         MockTime time = new MockTime();
         AtomicLong lastIdleTimeMs = new AtomicLong(0);
+        AtomicLong lastCurrentTimeMs = new AtomicLong(0);
 
         try (KafkaEventQueue queue = new KafkaEventQueue(
                 time,
                 logContext,
                 "testIdleTimeCallback",
                 EventQueue.VoidEvent.INSTANCE,
-                (idleDuration, currentTime) -> 
lastIdleTimeMs.set(idleDuration))) {
+                (idleDuration, currentTime) -> {
+                    lastIdleTimeMs.set(idleDuration);
+                    lastCurrentTimeMs.set(currentTime);
+                })) {
             time.sleep(2);
             assertEquals(0, lastIdleTimeMs.get(), "Last idle time should be 
0ms");
 
@@ -447,6 +451,7 @@ public class KafkaEventQueueTest {
             }));
             assertEquals("event1-processed", event1.get());
 
+            long timeBeforeWait = time.milliseconds();
             long waitTime5Ms = 5;
             time.sleep(waitTime5Ms);
             CompletableFuture<String> event2 = new CompletableFuture<>();
@@ -456,8 +461,10 @@ public class KafkaEventQueueTest {
             }));
             assertEquals("event2-processed", event2.get());
             assertEquals(waitTime5Ms, lastIdleTimeMs.get(), "Idle time should 
be " + waitTime5Ms + "ms, was: " + lastIdleTimeMs.get());
+            assertEquals(timeBeforeWait + waitTime5Ms, 
lastCurrentTimeMs.get(), "Current time should be " + (timeBeforeWait + 
waitTime5Ms) + "ms, was: " + lastCurrentTimeMs.get());
 
             // Test 2: Deferred event
+            long timeBeforeDeferred = time.milliseconds();
             long waitTime2Ms = 2;
             CompletableFuture<Void> deferredEvent2 = new CompletableFuture<>();
             queue.scheduleDeferred("deferred2",
@@ -466,6 +473,7 @@ public class KafkaEventQueueTest {
             time.sleep(waitTime2Ms);
             deferredEvent2.get();
             assertEquals(waitTime2Ms, lastIdleTimeMs.get(), "Idle time should 
be " + waitTime2Ms + "ms, was: " + lastIdleTimeMs.get());
+            assertEquals(timeBeforeDeferred + waitTime2Ms, 
lastCurrentTimeMs.get(), "Current time should be " + (timeBeforeDeferred + 
waitTime2Ms) + "ms, was: " + lastCurrentTimeMs.get());
         }
     }
 }