# ignite-1017: review
Project: http://git-wip-us.apache.org/repos/asf/incubator-ignite/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-ignite/commit/5d09ed1b Tree: http://git-wip-us.apache.org/repos/asf/incubator-ignite/tree/5d09ed1b Diff: http://git-wip-us.apache.org/repos/asf/incubator-ignite/diff/5d09ed1b Branch: refs/heads/ignite-sprint-7 Commit: 5d09ed1b3d295efb0670aaa943a0c3eb9c3a7267 Parents: 5b237e1 Author: ashutak <ashu...@gridgain.com> Authored: Fri Jun 26 17:53:22 2015 +0300 Committer: ashutak <ashu...@gridgain.com> Committed: Fri Jun 26 17:53:22 2015 +0300 ---------------------------------------------------------------------- .../org/apache/ignite/cluster/ClusterGroup.java | 16 ---------------- .../internal/cluster/ClusterGroupAdapter.java | 7 ------- .../internal/cluster/IgniteClusterAsyncImpl.java | 5 ----- 3 files changed, 28 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-ignite/blob/5d09ed1b/modules/core/src/main/java/org/apache/ignite/cluster/ClusterGroup.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/cluster/ClusterGroup.java b/modules/core/src/main/java/org/apache/ignite/cluster/ClusterGroup.java index 9627f76..62f3027 100644 --- a/modules/core/src/main/java/org/apache/ignite/cluster/ClusterGroup.java +++ b/modules/core/src/main/java/org/apache/ignite/cluster/ClusterGroup.java @@ -131,22 +131,6 @@ public interface ClusterGroup { * @param name Name of the attribute. * @param val Optional attribute value to match. * @return Cluster group for nodes containing specified attribute. - * - * @deprecated use {@link ClusterGroup#forAttribute(String name, @Nullable Object val} - */ - public ClusterGroup forAttribute(String name, @Nullable String val); - - /** - * Creates a new cluster group for nodes containing given name and value - * specified in user attributes. - * <p> - * User attributes for every node are optional and can be specified in - * grid node configuration. See {@link IgniteConfiguration#getUserAttributes()} - * for more information. - * - * @param name Name of the attribute. - * @param val Optional attribute value to match. - * @return Cluster group for nodes containing specified attribute. */ public ClusterGroup forAttribute(String name, @Nullable Object val); http://git-wip-us.apache.org/repos/asf/incubator-ignite/blob/5d09ed1b/modules/core/src/main/java/org/apache/ignite/internal/cluster/ClusterGroupAdapter.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/cluster/ClusterGroupAdapter.java b/modules/core/src/main/java/org/apache/ignite/internal/cluster/ClusterGroupAdapter.java index 414f5ba..6c42067 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/cluster/ClusterGroupAdapter.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/cluster/ClusterGroupAdapter.java @@ -345,13 +345,6 @@ public class ClusterGroupAdapter implements ClusterGroupEx, Externalizable { } /** {@inheritDoc} */ - @Override public final ClusterGroup forAttribute(String name, @Nullable final String val) { - A.notNull(name, "n"); - - return forPredicate(new AttributeFilter(name, val)); - } - - /** {@inheritDoc} */ @Override public final ClusterGroup forAttribute(String name, @Nullable final Object val) { A.notNull(name, "n"); http://git-wip-us.apache.org/repos/asf/incubator-ignite/blob/5d09ed1b/modules/core/src/main/java/org/apache/ignite/internal/cluster/IgniteClusterAsyncImpl.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/cluster/IgniteClusterAsyncImpl.java b/modules/core/src/main/java/org/apache/ignite/internal/cluster/IgniteClusterAsyncImpl.java index f676261..01c62b7 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/cluster/IgniteClusterAsyncImpl.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/cluster/IgniteClusterAsyncImpl.java @@ -192,11 +192,6 @@ public class IgniteClusterAsyncImpl extends AsyncSupportAdapter<IgniteCluster> } /** {@inheritDoc} */ - @Override public ClusterGroup forAttribute(String name, @Nullable String val) { - return cluster.forAttribute(name, val); - } - - /** {@inheritDoc} */ @Override public ClusterGroup forAttribute(String name, @Nullable Object val) { return cluster.forAttribute(name, val); }
