# disco spi usability - doc and warning messages on failure detection speed up
Project: http://git-wip-us.apache.org/repos/asf/incubator-ignite/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-ignite/commit/fc81bcfd Tree: http://git-wip-us.apache.org/repos/asf/incubator-ignite/tree/fc81bcfd Diff: http://git-wip-us.apache.org/repos/asf/incubator-ignite/diff/fc81bcfd Branch: refs/heads/ignite-gg-10411 Commit: fc81bcfd0a4fd20e4322a060d7745754f14767e1 Parents: 31cf802 Author: Yakov Zhdanov <yzhda...@gridgain.com> Authored: Thu Jun 18 15:08:33 2015 +0300 Committer: Yakov Zhdanov <yzhda...@gridgain.com> Committed: Thu Jun 18 15:08:33 2015 +0300 ---------------------------------------------------------------------- .../java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java | 4 ++++ .../org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpi.java | 7 ++++--- 2 files changed, 8 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-ignite/blob/fc81bcfd/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java b/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java index e9a949a..f7b6de9 100644 --- a/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java +++ b/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java @@ -2320,6 +2320,10 @@ class ServerImpl extends TcpDiscoveryImpl { for (TcpDiscoveryNode n : failedNodes) msgWorker.addMessage(new TcpDiscoveryNodeFailedMessage(locNodeId, n.id(), n.internalOrder())); + + LT.warn(log, null, "Local node has detected failed nodes and started cluster-wide procedure. " + + "To speed up failure detection please see 'Failure Detection' section under javadoc" + + "for 'TcpDiscoverySpi'"); } } http://git-wip-us.apache.org/repos/asf/incubator-ignite/blob/fc81bcfd/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpi.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpi.java b/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpi.java index 9a26867..d7c33a5 100644 --- a/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpi.java +++ b/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpi.java @@ -64,9 +64,9 @@ import java.util.concurrent.atomic.*; * {@link TcpDiscoveryIpFinder} about self start (stops when send succeeds) * and then this info goes to coordinator. When coordinator processes join request * and issues node added messages and all other nodes then receive info about new node. - * <h1 class="header">Configuration</h1> - * <h2 class="header">Important Notice</h2> - * Configuration defaults are chosen to make possible for discovery SPI to reliably work on + * <h1 class="header">Failure Detection</h1> + * Configuration defaults (see Configuration section below for details) + * are chosen to make possible for discovery SPI work reliably on * most of hardware and virtual deployments, but this has made failure detection time worse. * <p> * For stable low-latency networks the following more aggressive settings are recommended @@ -76,6 +76,7 @@ import java.util.concurrent.atomic.*; * <li>Socket timeout (see {@link #setSocketTimeout(long)}) - 200ms</li> * <li>Message acknowledgement timeout (see {@link #setAckTimeout(long)}) - 50ms</li> * </ul> + * <h1 class="header">Configuration</h1> * <h2 class="header">Mandatory</h2> * There are no mandatory configuration parameters. * <h2 class="header">Optional</h2>
