# IGNITE-598: Review comments.
Project: http://git-wip-us.apache.org/repos/asf/incubator-ignite/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-ignite/commit/d3ceb033 Tree: http://git-wip-us.apache.org/repos/asf/incubator-ignite/tree/d3ceb033 Diff: http://git-wip-us.apache.org/repos/asf/incubator-ignite/diff/d3ceb033 Branch: refs/heads/ignite-598 Commit: d3ceb0336aaab242f0d88725a811507c105eb2b1 Parents: ea315bf Author: vozerov-gridgain <voze...@gridgain.com> Authored: Tue Mar 31 12:16:41 2015 +0300 Committer: vozerov-gridgain <voze...@gridgain.com> Committed: Tue Mar 31 12:16:41 2015 +0300 ---------------------------------------------------------------------- .../org/apache/ignite/configuration/CacheConfiguration.java | 4 ++++ .../ignite/internal/processors/plugin/CachePluginManager.java | 2 +- .../internal/processors/plugin/IgnitePluginProcessor.java | 3 ++- .../main/java/org/apache/ignite/plugin/CachePluginContext.java | 5 +++++ 4 files changed, 12 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-ignite/blob/d3ceb033/modules/core/src/main/java/org/apache/ignite/configuration/CacheConfiguration.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/configuration/CacheConfiguration.java b/modules/core/src/main/java/org/apache/ignite/configuration/CacheConfiguration.java index b344777..afdc857 100644 --- a/modules/core/src/main/java/org/apache/ignite/configuration/CacheConfiguration.java +++ b/modules/core/src/main/java/org/apache/ignite/configuration/CacheConfiguration.java @@ -1581,6 +1581,8 @@ public class CacheConfiguration<K, V> extends MutableConfiguration<K, V> { } /** + * // TODO: Docs + * * @return Cache plugin configurations. */ public CachePluginConfiguration[] getCachePluginConfigurations() { @@ -1588,6 +1590,8 @@ public class CacheConfiguration<K, V> extends MutableConfiguration<K, V> { } /** + * // TODO: Docs + * * @param cachePluginCfgs Cache plugin configurations. */ public void setCachePluginConfigurations(CachePluginConfiguration... cachePluginCfgs) { http://git-wip-us.apache.org/repos/asf/incubator-ignite/blob/d3ceb033/modules/core/src/main/java/org/apache/ignite/internal/processors/plugin/CachePluginManager.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/plugin/CachePluginManager.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/plugin/CachePluginManager.java index 6260ace..5b742c3 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/processors/plugin/CachePluginManager.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/plugin/CachePluginManager.java @@ -78,6 +78,7 @@ public class CachePluginManager extends GridCacheManagerAdapter { * @param cl Type of cache plugin configuration. * @return Cache plugin configuration by type from cache configuration or <code>null</code>. */ + // TODO: cachePluginConfig -> cachePluginConfiguration public static <C extends CachePluginConfiguration> C cachePluginConfig( CacheConfiguration cfg, Class<C> cl) { if (cfg.getCachePluginConfigurations() != null) { @@ -109,6 +110,5 @@ public class CachePluginManager extends GridCacheManagerAdapter { return (T)new GridOsCacheDrManager(); throw new IgniteException("Unsupported component type: " + cls); - } } http://git-wip-us.apache.org/repos/asf/incubator-ignite/blob/d3ceb033/modules/core/src/main/java/org/apache/ignite/internal/processors/plugin/IgnitePluginProcessor.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/plugin/IgnitePluginProcessor.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/plugin/IgnitePluginProcessor.java index cb06d3b..9d1e92b 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/processors/plugin/IgnitePluginProcessor.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/plugin/IgnitePluginProcessor.java @@ -123,7 +123,8 @@ public class IgnitePluginProcessor extends GridProcessorAdapter { @Nullable public <T extends PluginProvider> T pluginProvider(String name) { return (T)plugins.get(name); } - + + // TODO: REmove? public <T extends PluginContext> T pluginContext(String name) { PluginProvider provider = pluginProvider(name); http://git-wip-us.apache.org/repos/asf/incubator-ignite/blob/d3ceb033/modules/core/src/main/java/org/apache/ignite/plugin/CachePluginContext.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/plugin/CachePluginContext.java b/modules/core/src/main/java/org/apache/ignite/plugin/CachePluginContext.java index 6e6b99c4..4238c3a 100644 --- a/modules/core/src/main/java/org/apache/ignite/plugin/CachePluginContext.java +++ b/modules/core/src/main/java/org/apache/ignite/plugin/CachePluginContext.java @@ -30,6 +30,8 @@ public interface CachePluginContext<C extends CachePluginConfiguration> { /** * @return Plugin cache configuration. */ + // TODO: cacheConfiguration() + // TODO: C extends cachePluginConfiguration public C cachePluginConfiguration(); /** @@ -42,6 +44,7 @@ public interface CachePluginContext<C extends CachePluginConfiguration> { */ public Ignite grid(); + // TODO: Remove public <T extends PluginContext> T pluginContext(String name); /** @@ -52,6 +55,7 @@ public interface CachePluginContext<C extends CachePluginConfiguration> { * @see #localNode() * @see org.apache.ignite.spi.discovery.DiscoverySpi */ + // TODO: Remove public Collection<ClusterNode> nodes(); /** @@ -61,6 +65,7 @@ public interface CachePluginContext<C extends CachePluginConfiguration> { * @return Local grid node. * @see org.apache.ignite.spi.discovery.DiscoverySpi */ + // TODO: Remove public ClusterNode localNode(); /**
