slbotbm commented on PR #2852: URL: https://github.com/apache/iggy/pull/2852#issuecomment-4052910042
@amlel-el-mahrouss I did not create a function like `make_ffi` since that is not a helpful abstraction. If a person other than you or me looks at the code, they will have difficulty understanding the code just from looking at `make_ffi`. I do not deny that abstractions are required (I utilize rust's `From` trait to convert from and to ffi), but I feel that these abstractions are discovered after spending a significant amount of time developing and refactoring the code. Pre-mature abstractions lead to difficulty in maintaining and understanding the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
