hubcio commented on code in PR #2879:
URL: https://github.com/apache/iggy/pull/2879#discussion_r2923867415
##########
core/server/src/shard/system/messages.rs:
##########
@@ -356,6 +356,10 @@ impl IggyShard {
)
.await;
+ if batch.count() == 0 {
+ return Ok(());
+ }
Review Comment:
you're right, step 1 does hit that path - my bad, sorry. still, it'd be nice
to have it as its own explicit step so it's obvious we're regression-testing
that specific fix, not just as a side effect of the dedupcheck.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
