chengxilo commented on PR #2914:
URL: https://github.com/apache/iggy/pull/2914#issuecomment-4034978177
#2863 might be a bit misleading, it's my fault since at that moment I
thought it is doable. However, after reading your code. Instead of introducing
an option like -race, I think maybe we could add another $SDK choice such as
`go-race` instead of a `-race` flag.
Discard `-race` option would simplify the implementation and make the script
easier to read. And not every SDK needs data race detection (to be honest I
think only go and C/C++ will need this).
The structure could look something like this:
```bash
case "$SDK" in
rust) run_suite rust-bdd "๐ฆ" "Running Rust BDD tests" ;;
python) run_suite python-bdd "๐" "Running Python BDD tests" ;;
go) run_suite go-bdd "๐น" "Running Go BDD tests" ;;
go-race) run_suite go-bdd "๐นโก" "Running Go BDD tests with data race
detector" ;;
node) run_suite node-bdd "๐ข๐" "Running Node BDD tests" ;;
csharp) run_suite csharp-bdd "๐ท" "Running C# BDD tests" ;;
java) run_suite java-bdd "โ" "Running Java BDD tests" ;;
all)
run_suite rust-bdd "๐ฆ" "Running Rust BDD tests" || exit $?
run_suite python-bdd "๐" "Running Python BDD tests" || exit $?
run_suite go-bdd "๐น" "Running Go BDD tests" || exit $?
run_suite go-bdd "๐นโก" "Running Go BDD tests with data race
detector" || exit $?
run_suite node-bdd "๐ข๐" "Running Node BDD tests" || exit $?
run_suite csharp-bdd "๐ท" "Running C# BDD tests" || exit $?
run_suite java-bdd "โ" "Running Java BDD tests" || exit $?
;;
clean)
cleanup; exit 0 ;;
*)
log "โ Unknown SDK: ${SDK}"
log "๐ Usage: $0 [rust|python|go|node|csharp|java|all|clean] [-race]
[feature_file]"
exit 2 ;;
esac
```
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
