numinnex commented on code in PR #2887:
URL: https://github.com/apache/iggy/pull/2887#discussion_r2911569101
##########
core/common/src/types/consensus/header.rs:
##########
@@ -201,14 +276,15 @@ impl ConsensusHeader for GenericHeader {
const COMMAND: Command2 = Command2::Reserved;
fn operation(&self) -> Operation {
- Operation::Default
+ Operation::Reserved
}
fn command(&self) -> Command2 {
Review Comment:
Do we need to store teh command as u8 on the header, instead of `Command2`
enum ?
##########
core/common/src/types/consensus/header.rs:
##########
@@ -201,14 +276,15 @@ impl ConsensusHeader for GenericHeader {
const COMMAND: Command2 = Command2::Reserved;
fn operation(&self) -> Operation {
- Operation::Default
+ Operation::Reserved
}
fn command(&self) -> Command2 {
Review Comment:
We construct the header thgrough the `try_from_bytes` method from bytemuck,
which has the validation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
