amlel-el-mahrouss commented on PR #2852:
URL: https://github.com/apache/iggy/pull/2852#issuecomment-4025891991
@slbotbm Here's my review:
What's good:
- Separation of concerns is good. (Using FFI, and Rust)
- Every unit has a clear purpose and does it well.
- Testing coverage is here. (Using GTest!)
Additional questions:
- Why not instead of:
```rust
ffi::Identifier {
kind,
length: identifier.length,
value: identifier.value,
}
```
why not: `identifier.make_ffi(kind)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
