gomnitrix commented on PR #2794: URL: https://github.com/apache/iggy/pull/2794#issuecomment-3944651881
> looks good, but after this change, the partition_exists check in store_consumer_offset (consumer_offsets.rs:54-63) is redundant - validate_partition_offset already returns PartitionNotFound when get_partition_stats_by_ids returns None.could be removed to avoid the extra metadata read. @hubcio Thanks for pointing that out! I just removed the redundant block to save the extra read and pushed the update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
