nsivabalan commented on code in PR #18337:
URL: https://github.com/apache/hudi/pull/18337#discussion_r3088580297
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanActionExecutor.java:
##########
@@ -213,17 +215,18 @@ private HoodieCleanMetadata runClean(HoodieTable<T, I, K,
O> table, HoodieInstan
}
List<HoodieCleanStat> cleanStats = clean(context, cleanerPlan);
+ table.getMetaClient().reloadActiveTimeline();
+ HoodieCleanMetadata metadata;
if (cleanStats.isEmpty()) {
- return HoodieCleanMetadata.newBuilder().build();
+ metadata = createEmptyCleanMetadata(cleanerPlan, inflightInstant,
timer.endTimer());
+ } else {
+ metadata = CleanerUtils.convertCleanMetadata(
+ inflightInstant.requestedTime(),
+ Option.of(timer.endTimer()),
+ cleanStats,
+ cleanerPlan.getExtraMetadata()
+ );
Review Comment:
cleanStats can never be empty without partitionsToBeDeleted being empty. So,
we should be good here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
