rahil-c commented on code in PR #18375: URL: https://github.com/apache/hudi/pull/18375#discussion_r3069731925
########## hudi-common/src/main/java/org/apache/hudi/common/table/read/UpdateProcessor.java: ########## @@ -136,18 +140,54 @@ protected BufferedRecord<T> handleNonDeletes(BufferedRecord<T> previousRecord, B Review Comment: **[High]** This branch uses `record.getSchema() != recordAvroSchema` as a heuristic to detect cached ExpressionPayload records. But schema inequality can also occur during legitimate schema evolution (e.g., a reader schema that differs from the writer schema). This heuristic conflates two unrelated conditions. Could we instead use an explicit signal (e.g. a boolean flag from the RecordContext indicating the record came from the cache) rather than inferring intent from schema comparison? Note: If this is not specific to the lance SQL changes then feel free to ignore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
