voonhous commented on code in PR #18488:
URL: https://github.com/apache/hudi/pull/18488#discussion_r3067733277
##########
hudi-spark-datasource/hudi-spark3.5.x/src/main/scala/org/apache/spark/sql/parser/HoodieSpark3_5ExtendedSqlAstBuilder.scala:
##########
@@ -2591,7 +2591,7 @@ class HoodieSpark3_5ExtendedSqlAstBuilder(conf: SQLConf,
delegate: ParserInterfa
* Resolve/create a primitive type.
*/
override def visitPrimitiveDataType(ctx: PrimitiveDataTypeContext): DataType
= withOrigin(ctx) {
- val dataType = ctx.identifier.getText.toLowerCase(Locale.ROOT)
+ val dataType = ctx.typeName.getText.toLowerCase(Locale.ROOT)
Review Comment:
No risk. IIRC, Our extended grammar is only triggered if `isHoodieCommand`
is true. Having a decimal type will not reach this extended grammar as we only
added blob and vector to the whitelist to be routed to the extended grammar
evaluation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
