rahil-c commented on code in PR #18480:
URL: https://github.com/apache/hudi/pull/18480#discussion_r3067074442


##########
hudi-sync/hudi-hive-sync/src/test/java/org/apache/hudi/hive/util/TestHiveSchemaUtil.java:
##########
@@ -172,6 +174,18 @@ void testSchemaTypeConversion() throws IOException {
     expected.put("`time_micros_field`", "bigint");
     expected.put("`decimal_field`", "DECIMAL(10 , 2)");
     expected.put("`uuid_field`", "binary");
+    expected.put("`vector_field`", "binary");
     assertEquals(expected, actual);
   }
+
+  @Test
+  void testVariantTypeConversion() {

Review Comment:
   Is this suppose to be added in this vector PR? Can you add a test for vector 
here instead



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to