yihua commented on code in PR #18295:
URL: https://github.com/apache/hudi/pull/18295#discussion_r3067025618


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieLockConfig.java:
##########
@@ -241,6 +248,16 @@ public class HoodieLockConfig extends HoodieConfig {
   @Deprecated
   public static final String LOCK_PROVIDER_CLASS_PROP = 
LOCK_PROVIDER_CLASS_NAME.key();
 
+  // Lock provider class names from modules not directly accessible in 
hudi-client-common.

Review Comment:
   Given that MDT write operations are critical, it is not quite safe to expose 
new APIs of `SparkRDDWriteClient.performAsyncTableServicesInMDT`, and users not 
aware of what they are doing can easily corrupt MDT.  So, given that it is an 
advanced usage, I would suggest avoiding a new public API and leveraging the 
lock config.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to