yihua commented on code in PR #18448:
URL: https://github.com/apache/hudi/pull/18448#discussion_r3067020386
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java:
##########
Review Comment:
🤖 **Line 1239:** The `heartbeatClient.stop()` call is still only on the
success path (after `return true`). If `table.rollback()` throws, the heartbeat
is never stopped, which blocks other writers from attempting the rollback until
it naturally expires. This was flagged in the previous review — could you wrap
the rollback execution + stop in a try/finally? Something like:
```java
try {
// execute rollback...
} finally {
if (config.isExclusiveRollbackEnabled()) {
heartbeatClient.stop(rollbackInstantTimeOpt.get());
}
}
```
<sub><i>- Generated by an AI agent and may contain mistakes. Please verify
any suggestions before applying.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
