yihua commented on code in PR #18417:
URL: https://github.com/apache/hudi/pull/18417#discussion_r3054637190
##########
hudi-common/src/main/java/org/apache/hudi/BaseHoodieTableFileIndex.java:
##########
@@ -501,7 +527,10 @@ private List<StoragePathInfo>
listPartitionPathFiles(List<PartitionPath> partiti
return result;
Review Comment:
🤖 Same as above — the `finally` fires after the `catch` rethrows as
`HoodieIOException`, so the DEBUG line "it took Xms to fetch files for N
uncached partitions via getAllFilesInPartitions" is logged even on failure. The
message implies the fetch completed. A neutral phrasing like "time spent
attempting getAllFilesInPartitions" would avoid the ambiguity.
🤖 *This review comment was generated by an AI agent and may contain
mistakes. Please verify any suggestions before applying.*
##########
hudi-common/src/main/java/org/apache/hudi/BaseHoodieTableFileIndex.java:
##########
Review Comment:
🤖 **Line 362:** This still logs "it took Xms to filter Y files into file
slices across Z partitions" even when the body throws — now at DEBUG level,
which reduces the noise, but the message still reads as a successful
completion. Could this be rephrased to something like "time spent in
filterFiles attempt" so it's unambiguous on both paths?
🤖 *This review comment was generated by an AI agent and may contain
mistakes. Please verify any suggestions before applying.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
