yihua commented on code in PR #18483:
URL: https://github.com/apache/hudi/pull/18483#discussion_r3050999268


##########
hudi-gcp/src/main/java/org/apache/hudi/gcp/bigquery/BigQuerySchemaResolver.java:
##########
@@ -146,6 +146,7 @@ private Field getField(HoodieSchema fieldSchema, String 
name, boolean nullable)
         standardSQLTypeName = StandardSQLTypeName.NUMERIC;
         break;
       case RECORD:
+      case VARIANT:

Review Comment:
   🤖 Now that VARIANT is handled here, it might be worth also adding `case 
BLOB:` in this same switch — `SparkSchemaUtils` and `HiveSchemaUtil` already 
cover BLOB, so BigQuery is currently the odd one out and would still throw 
`RuntimeException` for BLOB fields. Happy to leave it as a follow-up if out of 
scope, just flagging the asymmetry.
   
   🤖 *This review comment was generated by an AI agent and may contain 
mistakes. Please verify any suggestions before applying.*



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to