wombatu-kun commented on code in PR #18481:
URL: https://github.com/apache/hudi/pull/18481#discussion_r3050640638


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/catalog/HoodieHiveCatalog.java:
##########
@@ -637,6 +637,14 @@ private Table instantiateHiveTable(ObjectPath tablePath, 
CatalogBaseTable table,
     }
 
     HoodieFileFormat baseFileFormat = HoodieFileFormat.PARQUET;
+    String baseFileFormatStr = 
properties.get(HoodieTableConfig.BASE_FILE_FORMAT.key());
+    if (baseFileFormatStr != null) {
+      HoodieFileFormat configuredFormat = 
HoodieFileFormat.valueOf(baseFileFormatStr.toUpperCase());
+      if (configuredFormat == HoodieFileFormat.LANCE) {
+        throw new 
HoodieValidationException(HoodieFileFormat.LANCE_SPARK_ONLY_ERROR_MSG);
+      }
+      baseFileFormat = configuredFormat;

Review Comment:
   Not intentional, reverted change of `baseFileFormat`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to