cshuo commented on code in PR #18348:
URL: https://github.com/apache/hudi/pull/18348#discussion_r3050356700
##########
hudi-common/src/main/java/org/apache/hudi/metadata/MetadataPartitionType.java:
##########
@@ -439,22 +439,22 @@ public static List<MetadataPartitionType>
getMetadataPartitionsNeedingWriteStatu
return Collections.singletonList(MetadataPartitionType.RECORD_INDEX);
}
- /**
- * Returns the set of all metadata partition names.
- */
- public static Set<String> getAllPartitionPaths() {
- return Arrays.stream(getValidValues())
- .map(MetadataPartitionType::getPartitionPath)
- .collect(Collectors.toSet());
- }
-
/**
* Returns the set of all valid metadata partition types. Prefer using this
method over {@link #values()}.
*/
- public static MetadataPartitionType[] getValidValues() {
- // ALL_PARTITIONS is just another record type in FILES partition
+ public static MetadataPartitionType[] getValidValues(HoodieTableVersion
tableVersion) {
+ if (tableVersion.greaterThanOrEquals(HoodieTableVersion.EIGHT)) {
+ // ALL_PARTITIONS is just another record type in FILES partition
+ return EnumSet.complementOf(EnumSet.of(
Review Comment:
yes, it's intentional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
