nbalajee commented on code in PR #18279:
URL: https://github.com/apache/hudi/pull/18279#discussion_r3047965601
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/table/action/rollback/TestRollbackHelper.java:
##########
@@ -84,9 +83,9 @@ void tearDown() throws IOException {
storage.deleteDirectory(basePath);
}
- @ParameterizedTest
- @ValueSource(strings = {"SIX", "EIGHT"})
- void
testMaybeDeleteAndCollectStatsWithMultipleRequestsPerFileGroup(HoodieTableVersion
tableVersion) throws IOException {
+ @Test
+ void testMaybeDeleteAndCollectStatsWithMultipleRequestsPerFileGroup() throws
IOException {
Review Comment:
V6 uses RollbackHelperV1 (appends rollback command blocks) while V8 uses
RollbackHelper (deletes files). The helper class, method signatures, and
expected results all differ. A single parameterized test cannot cover both.
Hence, separated them into two functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
