nbalajee commented on code in PR #18279: URL: https://github.com/apache/hudi/pull/18279#discussion_r3047180867
########## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/RollbackHelper.java: ########## Review Comment: Agree that it is a valid improvement/suggestion. In the original code, FSUtils.getAllLogFiles(), line 521, uses a similar contains() filter on the logfile extension. My preference/recommendation is to take this up in a followup PR to tighten the filter, which is applicable to FSUtils.getAllLogFiles() and other places. Let me know if you would rather have it fixed here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
