danny0405 commented on code in PR #18384:
URL: https://github.com/apache/hudi/pull/18384#discussion_r3042446868
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/io/storage/hadoop/HoodieAvroParquetWriter.java:
##########
@@ -56,21 +57,39 @@ public HoodieAvroParquetWriter(StoragePath file,
String instantTime,
TaskContextSupplier taskContextSupplier,
boolean populateMetaFields) throws
IOException {
+ this(file, parquetConfig, instantTime, taskContextSupplier,
populateMetaFields, null);
+ }
+
+ @SuppressWarnings({"unchecked", "rawtypes"})
+ public HoodieAvroParquetWriter(StoragePath file,
+ HoodieParquetConfig<HoodieAvroWriteSupport>
parquetConfig,
+ String instantTime,
+ TaskContextSupplier taskContextSupplier,
+ boolean populateMetaFields,
+ boolean[] populateIndividualMetaFields)
throws IOException {
super(file, (HoodieParquetConfig) parquetConfig);
this.fileName = file.getName();
this.writeSupport = parquetConfig.getWriteSupport();
this.instantTime = instantTime;
this.taskContextSupplier = taskContextSupplier;
this.populateMetaFields = populateMetaFields;
+ this.populateIndividualMetaFields = populateIndividualMetaFields;
}
@Override
public void writeAvroWithMetadata(HoodieKey key, IndexedRecord avroRecord)
throws IOException {
if (populateMetaFields) {
- prepRecordWithMetadata(key, avroRecord, instantTime,
- taskContextSupplier.getPartitionIdSupplier().get(),
getWrittenRecordCount(), fileName);
+ if (populateIndividualMetaFields != null) {
Review Comment:
The `populateMetaFields` has overlapping semantics with
`populateIndividualMetaFields`, this makes the metadata fields population much
more compliacated, do we need both of these two, is it possible we enforce the
existing support of `populateMetaFields` to either remove all the metadata
fields(with required fields still there) or keeping them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
