nsivabalan commented on code in PR #18295:
URL: https://github.com/apache/hudi/pull/18295#discussion_r3037687514
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieLockConfig.java:
##########
@@ -241,6 +248,16 @@ public class HoodieLockConfig extends HoodieConfig {
@Deprecated
public static final String LOCK_PROVIDER_CLASS_PROP =
LOCK_PROVIDER_CLASS_NAME.key();
+ // Lock provider class names from modules not directly accessible in
hudi-client-common.
Review Comment:
but the issue is, we can't confine those APIs just for the standalone tool
right. it will go in w/ the stand write client we have. And hence, anyone can
use it otherwise as well.
lets chat through this and take a call. I don't see lot of users might use
this feature for now. So, unless we plan to make this a major one, and make it
robust(either by adding separate locks for metadata table), don't wanna pollute
the write client meant for data table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
