rahil-c commented on code in PR #18432:
URL: https://github.com/apache/hudi/pull/18432#discussion_r3035880646
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/analysis/HoodieSparkBaseAnalysis.scala:
##########
@@ -310,6 +327,55 @@ case class ResolveReferences(spark: SparkSession) extends
Rule[LogicalPlan]
sparkAdapter.getCatalystPlanUtils.unapplyMergeIntoTable(plan)
}
+ private def resolveTableToDf(tableName: String): DataFrame = {
+ if (tableName.contains(StoragePath.SEPARATOR)) {
+ spark.read.format("hudi").load(tableName)
Review Comment:
I dont think it make sense in the user params to expose both a tablePath arg
and a tableName arg. The reason is then if the user passes both its kinda
awkward experience, and I think one argument can handle both pieces of
information. Maybe I just the naming to be less about `tableName` or
`tablePath` so its more clear and leave a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
