yihua commented on code in PR #18399:
URL: https://github.com/apache/hudi/pull/18399#discussion_r3035845384


##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/table/TestHoodieTableFactory.java:
##########
@@ -226,6 +227,14 @@ void testIndexTypeCheck() {
     this.conf.set(FlinkOptions.INDEX_GLOBAL_ENABLED, false);
     final MockContext sourceContext5 = MockContext.getInstance(this.conf, 
schema, "f2");
     assertThrows(IllegalArgumentException.class, () -> new 
HoodieTableFactory().createDynamicTableSink(sourceContext5));
+

Review Comment:
   🤖 nit: the comment reads a bit oddly — "Valid deferred RLI initialization" 
might be a typo? Something like `// Deferred RLI initialization is not 
supported for GLOBAL_RECORD_LEVEL_INDEX.` would be clearer.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to