yihua commented on code in PR #18463:
URL: https://github.com/apache/hudi/pull/18463#discussion_r3035002461
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/HiveIncrementalPuller.java:
##########
@@ -183,9 +183,12 @@ private void executeIncrementalSQL(String tempDbTable,
String tempDbTablePath, S
String storedAsClause = getStoredAsClause();
incrementalPullSQLTemplate.add("storedAsClause", storedAsClause);
- String incrementalSQL = new Scanner(new
File(config.incrementalSQLFile)).useDelimiter("\\Z").next();
+ String incrementalSQL;
+ try (Scanner sqlScanner = new Scanner(new
File(config.incrementalSQLFile))) {
+ incrementalSQL = sqlScanner.useDelimiter("\\Z").next();
+ }
if (!incrementalSQL.contains(config.sourceDb + "." + config.sourceTable)) {
- LOG.error("Incremental SQL does not have " + config.sourceDb + "." +
config.sourceTable
+ LOG.error("Incremental SQL does nothave " + config.sourceDb + "." +
config.sourceTable
Review Comment:
🤖 nit: looks like this change accidentally dropped the space — `"does
nothave"` should be `"does not have"`. The exception message two lines below
still reads correctly, but the log line will be garbled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
