yihua commented on PR #18432: URL: https://github.com/apache/hudi/pull/18432#issuecomment-4181049661
> ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18432?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report > ❌ Patch coverage is `72.39057%` with `82 lines` in your changes missing coverage. Please review. ✅ Project coverage is 68.55%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c19c701`](https://app.codecov.io/gh/apache/hudi/commit/c19c7015be6a668d29d20d9768eac87ee057e5a8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). ⚠️ Report is 10 commits behind head on master. > > [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18432?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Patch % Lines > [.../spark/sql/hudi/analysis/VectorDistanceUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18432?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2Fanalysis%2FVectorDistanceUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2h1ZGkvYW5hbHlzaXMvVmVjdG9yRGlzdGFuY2VVdGlscy5zY2FsYQ==) 55.17% [18 Missing and 8 partials ⚠️ ](https://app.codecov.io/gh/apache/hudi/pull/18432?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) > [...ogical/HoodieVectorSearchTableValuedFunction.scala](https://app.codecov.io/gh/apache/hudi/pull/18432?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fcatalyst%2Fplans%2Flogical%2FHoodieVectorSearchTableValuedFunction.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2NhdGFseXN0L3BsYW5zL2xvZ2ljYWwvSG9vZGllVmVjdG9yU2VhcmNoVGFibGVWYWx1ZWRGdW5jdGlvbi5zY2FsYQ==) 75.29% [13 Missing and 8 partials ⚠️ ](https://app.codecov.io/gh/apache/hudi/pull/18432?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) > [.../hudi/analysis/HoodieVectorSearchPlanBuilder.scala](https://app.codecov.io/gh/apache/hudi/pull/18432?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2Fanalysis%2FHoodieVectorSearchPlanBuilder.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2h1ZGkvYW5hbHlzaXMvSG9vZGllVmVjdG9yU2VhcmNoUGxhbkJ1aWxkZXIuc2NhbGE=) 79.20% [10 Missing and 11 partials ⚠️ ](https://app.codecov.io/gh/apache/hudi/pull/18432?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) > [...rk/sql/hudi/analysis/HoodieSparkBaseAnalysis.scala](https://app.codecov.io/gh/apache/hudi/pull/18432?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2Fanalysis%2FHoodieSparkBaseAnalysis.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2h1ZGkvYW5hbHlzaXMvSG9vZGllU3BhcmtCYXNlQW5hbHlzaXMuc2NhbGE=) 68.88% [7 Missing and 7 partials ⚠️ ](https://app.codecov.io/gh/apache/hudi/pull/18432?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) > Additional details and impacted files > ```diff > @@ Coverage Diff @@ > ## master #18432 +/- ## > ============================================ > + Coverage 68.52% 68.55% +0.03% > - Complexity 27968 28045 +77 > ============================================ > Files 2440 2447 +7 > Lines 134456 135051 +595 > Branches 16226 16357 +131 > ============================================ > + Hits 92138 92588 +450 > - Misses 35054 35151 +97 > - Partials 7264 7312 +48 > ``` > > [Flag](https://app.codecov.io/gh/apache/hudi/pull/18432/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Coverage Δ > [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18432/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) `44.26% <4.39%> (-0.08%)` ⬇️ > [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18432/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) `44.93% <ø> (-0.06%)` ⬇️ > [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18432/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) `48.46% <ø> (+0.08%)` ⬆️ > [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18432/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) `48.86% <72.39%> (+0.09%)` ⬆️ > [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18432/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) `45.51% <4.37%> (-0.14%)` ⬇️ > [utilities](https://app.codecov.io/gh/apache/hudi/pull/18432/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) `38.26% <4.39%> (-0.10%)` ⬇️ > Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. > > [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18432?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Coverage Δ > [...spark/sql/hudi/analysis/TableValuedFunctions.scala](https://app.codecov.io/gh/apache/hudi/pull/18432?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2Fanalysis%2FTableValuedFunctions.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2h1ZGkvYW5hbHlzaXMvVGFibGVWYWx1ZWRGdW5jdGlvbnMuc2NhbGE=) `100.00% <100.00%> (ø)` > [...rk/sql/hudi/analysis/HoodieSparkBaseAnalysis.scala](https://app.codecov.io/gh/apache/hudi/pull/18432?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2Fanalysis%2FHoodieSparkBaseAnalysis.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2h1ZGkvYW5hbHlzaXMvSG9vZGllU3BhcmtCYXNlQW5hbHlzaXMuc2NhbGE=) `73.00% <68.88%> (-1.17%)` ⬇️ > [...ogical/HoodieVectorSearchTableValuedFunction.scala](https://app.codecov.io/gh/apache/hudi/pull/18432?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fcatalyst%2Fplans%2Flogical%2FHoodieVectorSearchTableValuedFunction.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2NhdGFseXN0L3BsYW5zL2xvZ2ljYWwvSG9vZGllVmVjdG9yU2VhcmNoVGFibGVWYWx1ZWRGdW5jdGlvbi5zY2FsYQ==) `75.29% <75.29%> (ø)` > [.../hudi/analysis/HoodieVectorSearchPlanBuilder.scala](https://app.codecov.io/gh/apache/hudi/pull/18432?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2Fanalysis%2FHoodieVectorSearchPlanBuilder.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2h1ZGkvYW5hbHlzaXMvSG9vZGllVmVjdG9yU2VhcmNoUGxhbkJ1aWxkZXIuc2NhbGE=) `79.20% <79.20%> (ø)` > [.../spark/sql/hudi/analysis/VectorDistanceUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18432?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2Fanalysis%2FVectorDistanceUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2h1ZGkvYW5hbHlzaXMvVmVjdG9yRGlzdGFuY2VVdGlscy5zY2FsYQ==) `55.17% <55.17%> (ø)` > ... and [52 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18432/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) > > 🚀 New features to boost your workflow: @rahil-c could you check the lines that miss coverage and see if more tests should be added? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
