danny0405 commented on code in PR #12537:
URL: https://github.com/apache/hudi/pull/12537#discussion_r1908099351
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/functional/TestSparkConsistentBucketClustering.java:
##########
@@ -110,7 +115,7 @@ public void setup(int maxFileSize, Map<String, String>
options) throws IOExcepti
.withStorageConfig(HoodieStorageConfig.newBuilder().parquetMaxFileSize(maxFileSize).build())
.withClusteringConfig(HoodieClusteringConfig.newBuilder()
.withClusteringPlanStrategyClass(SparkConsistentBucketClusteringPlanStrategy.class.getName())
-
.withClusteringExecutionStrategyClass(SparkConsistentBucketClusteringExecutionStrategy.class.getName())
+ .withClusteringExecutionStrategyClass(single ?
SINGLE_SPARK_CONSISTENT_BUCKET_EXECUTION_STRATEGY :
SPARK_CONSISTENT_BUCKET_EXECUTION_STRATEGY)
Review Comment:
We should just keep one strategy if
`SINGLE_SPARK_CONSISTENT_BUCKET_EXECUTION_STRATEGY` is always better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
